fix: gracefully handle missing files during coverage upload - #778
Open
sentry[bot] wants to merge 1 commit into
Open
fix: gracefully handle missing files during coverage upload#778sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
codecov-cliwould crash with aFileNotFoundErrorduring a coverage upload if a file tracked by git was not present on the local filesystem. This commonly occurs with generated files (e.g.,*.g.dartin Flutter projects) that are committed to version control but might not be generated in a specific local environment.The root cause was that the
_get_file_fixesfunction incodecov_cli/services/upload/upload_collector.pyattempted to open such files without handlingFileNotFoundError.This fix adds an
except FileNotFoundErrorblock to_get_file_fixes. Now, if a git-tracked file is not found on disk, a warning will be logged, and the file will be skipped, allowing the coverage upload process to complete without interruption. This approach aligns with the existing error handling forUnicodeDecodeErrorandIsADirectoryErrorin the same function.Fixes CLI-GS
This PR was automatically generated by Sentry. You can adjust this setting at any time.